Redirect All Traffic to Rails #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not that standardization is strong in the project, but I noticed tab indentation is off a bit. |
Meatballs1
force-pushed
the
redirect_all
branch
from
0c1d622 to
92f7ae8
Compare
| @@ -1,6 +1,7 @@ | |||
| class Victim < ActiveRecord::Base | |||
| belongs_to :campaign | |||
| has_many :visits, dependent: :destroy | |||
| has_many :credentials, through: :visits | |||
| @@ -193,7 +146,7 @@ def apache_logs | |||
| def passwords | |||
| # display all password harvested within campaign | |||
| @campaign = Campaign.find(params[:id]) | |||
| @visits = @campaign.visits.where('extra LIKE ?', "%password%") | |||
| @visits = Visit.includes(:victim, :credential).joins(:victim, :credential).where(victims: { campaign_id: params[:id] }) | |||
There was a problem hiding this comment.
We really should consider moving this up into the Visit model with a scope
Conflicts: app/controllers/reports_controller.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current POC at the moment.
TODO:
I would imagine this constitutes a major version change as there will be backwards incompat with previous templates and a different methodology.