ci: fix containerfile build for monorepo layout #170
Conversation
Follow-up to #167.
| !apps/*/public/ | ||
| !apps/*/.next/ | ||
| !apps/*/*.ts | ||
| !apps/ |
There was a problem hiding this comment.
The line !apps/*/src/ looks to me like it should be sufficient to get the apps/web/src/* directory allowed, but it wasn't working. To resolve, I added !apps/ and I'm calling it a day.
There was a problem hiding this comment.
I completely assumed that !apps/*/src would expand to include any subdirectories so great catch!
| @@ -45,7 +45,7 @@ jobs: | |||
| with: | |||
| context: . | |||
| platforms: linux/amd64 | |||
| file: Containerfile | |||
| file: apps/web/Containerfile | |||
There was a problem hiding this comment.
The Containerfile moved, but the build "content" did not: the context remains the repo root.
| @@ -9,6 +9,7 @@ node_modules | |||
| .env.development.local | |||
| .env.test.local | |||
| .env.production.local | |||
| .envrc | |||
There was a problem hiding this comment.
I use a local .envrc file sometimes to test connecting a locally-built container to a remote DB URL.
| @@ -59,6 +62,6 @@ COPY --from=installer /app/apps/web/package.json . | |||
| # https://nextjs.org/docs/advanced-features/output-file-tracing | |||
| COPY --from=installer --chown=nextjs:nodejs /app/apps/web/.next/standalone ./ | |||
| COPY --from=installer --chown=nextjs:nodejs /app/apps/web/.next/static ./apps/web/.next/static | |||
| COPY --from=installer --chown=nextjs:nodejs /app/apps/web/public ./apps/web/public | |||
| # COPY --from=installer --chown=nextjs:nodejs /app/apps/web/public ./apps/web/public | |||
There was a problem hiding this comment.
AFAICT the ./apps/web/public/ dir doesn't exist and doesn't need to exist: the app works well without it.
| @@ -4,19 +4,22 @@ LABEL maintainer="team@penumbralabs.xyz" | |||
|
|
|||
| # provide pnpm globally for dep installing and building | |||
| FROM alpine AS base | |||
| ENV NEXT_TELEMETRY_DISABLED=1 | |||
There was a problem hiding this comment.
Porting this no-telem env var across all build stages...
There was a problem hiding this comment.
lol, great catch. Very obnoxious to keep track of.
|
Thanks for the PR and comments 👍 |
Follow-up to #167.