use in-memory db #43
Merged
use in-memory db #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
try-in-memory-db
branch
2 times, most recently
from
d9c7787 to
6dbe1d8
Compare
|
Updated based on discussion with @plaidfinch. Take a look? |
Uses the new storage init logic [0] to store sync state in memory. This will cause galileo to sync at service start to memory, and abjure any on-disk storage. Hat tip to @plaidfinch for explaining the type inference required by the view service changes. [0] penumbra-zone/penumbra#2372
conorsch
force-pushed
the
try-in-memory-db
branch
from
6dbe1d8 to
5e6f8dc
Compare
plaidfinch
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
This should work! What's nice about this is that while it shares the custody file for whatever pcli wallet is currently present, it doesn't touch that wallet's database, which means that you can run galileo and pcli concurrently and they won't step on each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to use the new storage init logic to store sync state in memory, which should cause galileo to sync at service start.