Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck in trader runtime loop #18

Open
conorsch opened this issue Jul 22, 2023 · 0 comments
Open

Stuck in trader runtime loop #18

conorsch opened this issue Jul 22, 2023 · 0 comments

Comments

@conorsch
Copy link
Contributor

conorsch commented Jul 22, 2023

Our preview deployment of Osiris has been stuck for a few hours:

❯ kubectl logs -f osiris-preview-654c9f844-wr4hd
Jul 21 21:35:22.952 DEBUG osiris::opt::serve: found valid trading symbols in Binance API symbols=["BTCUSD", "ATOMBTC", "ATOMUSD"]
Jul 21 21:35:23.083  INFO osiris::opt::serve: starting initial sync: please wait for sync to complete before requesting tokens
Jul 21 21:35:24.391  INFO osiris::opt::serve: initial sync complete
Jul 21 21:35:24.391 DEBUG osiris::binance_fetcher: running BinanceFetcher
^C

I'd expect to see it slinging transactions around. Discovered this while following up on #13. I believe the code is getting stuck on this line:

if rx.has_changed().unwrap() {

meaning that the result always evaluates to false, so the loop continues without actually taking any action. Will add some more logging for visibility.

Steps to reproduce

  1. check out main branch
  2. run: RUST_LOG=osiris=trace cargo run --release -- serve --node https://grpc.testnet-preview.penumbra.zone BTC ATOM USD
  3. observe that no transaction events are logged, program is stuck
conorsch added a commit that referenced this issue Jul 22, 2023
Trying to debug #18, wanted more logging data. This PR adds a bunch more
logging messages, with more still to come. I also ran `cargo clippy` and
`cargo fmt`, so the diff is a bit larger than it strictly needs to be. I
was careful to avoid changing functionality aside from logging.
conorsch added a commit that referenced this issue Jul 22, 2023
Trying to debug #18, wanted more logging data. This PR adds a bunch more
logging messages, with more still to come. I also ran `cargo clippy` and
`cargo fmt`, so the diff is a bit larger than it strictly needs to be. I
was careful to avoid changing functionality aside from logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant