delegator_vote: use balance commitment to the staked note

Co-authored-by: finch <finch@plaidfinch.net>
penumbra-zone · Sep 6, 2023 · b4cb9aa · b4cb9aa
1 parent 6a5e30b
commit b4cb9aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/crates/core/app/src/action_handler/actions/delegator_vote.rs b/crates/core/app/src/action_handler/actions/delegator_vote.rs
@@ -1,14 +1,13 @@
 use std::sync::Arc;
 
 use anyhow::{Context, Result};
+use ark_ff::Zero;
 use async_trait::async_trait;
+use decaf377::Fr;
 use penumbra_chain::TransactionContext;
 use penumbra_proof_params::DELEGATOR_VOTE_PROOF_VERIFICATION_KEY;
 use penumbra_storage::{StateRead, StateWrite};
-use penumbra_transaction::{
-    action::{DelegatorVote, DelegatorVoteBody},
-    IsAction,
-};
+use penumbra_transaction::action::{DelegatorVote, DelegatorVoteBody};
 
 use crate::{
     governance::{StateReadExt as _, StateWriteExt as _},
@@ -28,9 +27,9 @@ impl ActionHandler for DelegatorVote {
                     start_position,
                     nullifier,
                     rk,
-                    unbonded_amount: _, // Used to compute the balance commitment.
+                    value,
                     // Unused in stateless checks:
-                    value: _,
+                    unbonded_amount: _,
                     vote: _,     // Only used when executing the vote
                     proposal: _, // Checked against the current open proposals statefully
                 },
@@ -45,7 +44,7 @@ impl ActionHandler for DelegatorVote {
             .verify(
                 &DELEGATOR_VOTE_PROOF_VERIFICATION_KEY,
                 context.anchor,
-                self.balance_commitment(),
+                value.commit(Fr::zero()),
                 *nullifier,
                 *rk,
                 *start_position,

diff --git a/crates/core/transaction/src/plan/action/delegator_vote.rs b/crates/core/transaction/src/plan/action/delegator_vote.rs
@@ -1,4 +1,5 @@
 use ark_ff::UniformRand;
+use ark_ff::Zero;
 use decaf377::{FieldExt, Fq, Fr};
 use decaf377_rdsa::{Signature, SpendAuth};
 use penumbra_asset::{Balance, Value};
@@ -111,7 +112,7 @@ impl DelegatorVotePlan {
             *fvk.spend_verification_key(),
             *fvk.nullifier_key(),
             state_commitment_proof.root(),
-            self.balance().commit(Fr::from(0u64)),
+            self.staked_note.value().commit(Fr::zero()),
             self.nullifier(fvk),
             self.rk(fvk),
             self.start_position,