Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for governance tallying #1345

Open
Tracked by #1790
plaidfinch opened this issue Aug 31, 2022 · 2 comments
Open
Tracked by #1790

Unit tests for governance tallying #1345

plaidfinch opened this issue Aug 31, 2022 · 2 comments
Labels
A-governance Area: Governance A-node Area: System design and implementation for node software _P-low Priority: low
Milestone

Comments

@plaidfinch
Copy link
Collaborator

The Tally::evaluate function in the governance component has not been comprehensively tested, and @avahowell and I observed a confusing and unexpected proposal vote failure (when it should have passed). This function should be exhaustively tested very carefully.

@plaidfinch plaidfinch added A-node Area: System design and implementation for node software A-governance Area: Governance labels Aug 31, 2022
@plaidfinch plaidfinch added this to the Testnet #28 - Harpalyke milestone Aug 31, 2022
@plaidfinch plaidfinch self-assigned this Aug 31, 2022
@aubrika aubrika moved this to Todo in Testnet #31: Autonoe Sep 9, 2022
@avahowell avahowell moved this to Todo in Testnets Oct 7, 2022
@zbuc zbuc moved this from Todo to Future in Testnets Oct 21, 2022
@plaidfinch plaidfinch moved this from Future to Testnet 49: Pasiphae in Testnets Mar 10, 2023
@erwanor erwanor moved this from Testnet 49: Pasiphae to In Progress in Testnets Mar 16, 2023
@erwanor erwanor moved this from In Progress to Next in Testnets Apr 28, 2023
@plaidfinch plaidfinch moved this from Next to Testnet 53: Himalia in Testnets May 5, 2023
@erwanor erwanor moved this from Testnet 53: Himalia to Next in Testnets May 19, 2023
@erwanor
Copy link
Member

erwanor commented May 19, 2023

Moving back to Next because we're using the 53 column for items we are definitely trying to land, on a schedule.

@hdevalence
Copy link
Member

Blocked on #3588

@hdevalence hdevalence moved this from 🗄️ Backlog to Blocked in Penumbra Feb 9, 2024
@hdevalence hdevalence added the _P-low Priority: low label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-governance Area: Governance A-node Area: System design and implementation for node software _P-low Priority: low
Projects
Status: Blocked
Status: Next
Development

No branches or pull requests

5 participants