Release tracking issue: Governance

[plaidfinch]

A governance MVP consists of:

• proposal submission and withdrawal
• four kinds of proposal (signaling, emergency, parameter change, and DAO spend) and their implementations
• validator voting,
• delegator voting, and
• DAO interactions.

Penumbra proposals are controlled by a client-side state machine which burns and mints NFTs corresponding to the state of a proposal. There is no NoWithVeto vote, unlike in the Cosmos SDK; instead, there is a threshold of No votes (out of all total votes cast) which causes the proposal to be vetoed. This diagram shows the flow of a proposal from start to finish:

In the above, rounded grey boxes are actions submitted by the proposal author, rectangular colored boxes are the state of the proposal on chain, colored circles are outcomes of voting.

Completing governance is broken down into the following sequence of remaining work:

Initial cleanup

• Governance protobuf cleanup #1791
• Re-evaluate bespoke JSON shaping for governance proto types #1792

Refactoring and changing current functionality

• Replace governance auth sigs with proposal NFTs #1793

Delegator voting (PR #1881)

• Change nullifier set to track spend height and NoteSource combined #1882
• Eliminate NoWithVeto and replace with a percentage cutoff for deposit burning #1794
• Hand out tokens commemorating voting #1879
• Implement delegator voting #1795
• Roll over delegation tokens during voting #2027
• Don't forget votable delegation tokens in the view database #2028

Cleanup and finishing tallying (PR #2055)

• Remove num_rational from dependency tree #1466
• Fix up vote tallying and add tests #1796
• Fix chain halt logic so that the halt occurs after ABCI commit phase #1798
• Revisit parameter change proposals for cleanup #1797
• Report tally to pcli #2060

Validate parameter change proposals

• Provide updated ChainParams in CompactBlock #1221
• Provide TOML format for chain parameters #2067
• Determine governance chain parameters #1160
• Proposal voting period #1156

Implement the DAO (PR #2072)

• Implement DAO spend proposals (gated by chain parameter?) #1799
• DaoSpend action (only valid within DaoSpend proposal) #1154
• DaoDeposit action #1153
• DaoOutput action #2073

Allow DAO to interact with funding streams (also in PR #2072)

• Make funding streams an enum with one variant, the current one (a penumbra address) #1800
• Add an enum variant to funding streams to allow depositing into the DAO #1802

Make chain halts sticky

• Prevent un-intentional external restarts when chain tries to halt #2085

Supporting DAO interactions

• Design and implement transaction intents #2076
• Enable planning transactions "as if I were the DAO" #2077
• Enable pcli tx proposal template to specify the included DAO spend tx by intent #2080

Cleanup and documentation

• Better human-readable proposal TOML #2026
• Document how to use governance #2090
• Tracking issue: improve documentation coverage #2488
• Querying proposals doesn't show all active ones #2130

IBC actions

• IBC-related governance proposals #2173
• ibc: allow governance to amend counterparty clients #3024

Testing and assurance

• Ensure that we correctly update the token supply when tokens are converted from one type to another #1823
• Unit tests for governance tallying #1345
• Add governance state machine tests #2105

Further enhancements

• Change proposal duration to clock time rather than block time #1966

[conorsch]

We're in a good position to close out the next ~3-4 items on the checklist via #1881; but higher priority currently on unblocking Zpoken work, so this work might slip to a subsequent sprint.

[zbuc]

This has some subtasks that aren't marked V1, should they be?