Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chain halt logic so that the halt occurs after ABCI commit phase #1798

Closed
Tracked by #1790
, #1804
...
plaidfinch opened this issue Jan 5, 2023 · 0 comments · Fixed by #2055
Closed
Tracked by #1790
, #1804
...

Fix chain halt logic so that the halt occurs after ABCI commit phase #1798

plaidfinch opened this issue Jan 5, 2023 · 0 comments · Fixed by #2055
Assignees
@plaidfinch
Labels
A-governance Area: Governance E-week
Milestone
Upgrades

Comments

@plaidfinch
Copy link
Collaborator

plaidfinch commented Jan 5, 2023 •
edited
Loading

If the chain halts before ABCI commit, then restarting the chain will get stuck in a loop processing the same block and halting over and over again, rather than continuing afterwards. Instead of immediately calling process::exit, we should signal to the consensus worker that the chain should halt after the block is committed to storage.
@plaidfinch plaidfinch mentioned this issue Jan 5, 2023
Open
38 tasks
@plaidfinch plaidfinch added the A-governance Area: Governance label Jan 5, 2023
@plaidfinch plaidfinch self-assigned this Jan 5, 2023
@redshiftzero redshiftzero mentioned this issue Jan 6, 2023
Closed
@redshiftzero redshiftzero assigned erwanor and unassigned plaidfinch Jan 6, 2023
@redshiftzero redshiftzero moved this to Testnet 40: Themisto in Testnets Jan 6, 2023
@redshiftzero redshiftzero mentioned this issue Jan 6, 2023
Open
19 tasks
@redshiftzero redshiftzero moved this from Testnet 40: Themisto to Testnet 41 in Testnets Jan 13, 2023
@erwanor erwanor moved this from Testnet 41: Callirrhoe to Future in Testnets Jan 13, 2023
@erwanor erwanor added this to the Network upgrades milestone Feb 8, 2023
@erwanor erwanor added the E-week label Feb 8, 2023
@plaidfinch plaidfinch assigned plaidfinch and unassigned erwanor Feb 27, 2023
@plaidfinch plaidfinch moved this from Future to Testnet 47: Sinope in Testnets Feb 27, 2023
plaidfinch added a commit that referenced this issue Feb 27, 2023
@plaidfinch
Resolves #1798, implementing chain halt exit after commit finishes
f8f9730
@plaidfinch plaidfinch mentioned this issue Feb 27, 2023
Merged
plaidfinch added a commit that referenced this issue Feb 28, 2023
@plaidfinch
Resolves #1798, implementing chain halt exit after commit finishes
627ab5d
@plaidfinch plaidfinch linked a pull request Feb 28, 2023 that will close this issue
Tally votes from both delegators and validators to determine when proposals pass #2055
Merged
plaidfinch added a commit that referenced this issue Feb 28, 2023
@plaidfinch
Resolves #1798, implementing chain halt exit after commit finishes
fd09214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plaidfinch plaidfinch

Labels
A-governance Area: Governance E-week
Projects
No open projects
Testnets
Status: Testnet 47: Sinope
Milestone
Upgrades
2 participants
@plaidfinch @erwanor