Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Storage::ephemeral_test_instance() method #853

Closed
hdevalence opened this issue May 23, 2022 · 1 comment · Fixed by #1675
Closed

Create a Storage::ephemeral_test_instance() method #853

hdevalence opened this issue May 23, 2022 · 1 comment · Fixed by #1675
Labels
E-easy Effort: Easy good first issue A good issue for people without existing context on the project. help wanted Help on this issue is welcomed!

Comments

@hdevalence
Copy link
Member

I think the test in question is using tmpdirs to make a testing Storage instance. This is a side note, but along the way to fixing it, I think it'd be useful to move that code into the storage crate as a Storage::ephemeral_test_instance() method that returns (Self, Handle), where Handle is the RAII guard you get from the crate that makes temporary directories and cleans up the directory on drop.

Originally posted by @hdevalence in #797 (comment)
@hdevalence hdevalence added E-easy Effort: Easy help wanted Help on this issue is welcomed! good first issue A good issue for people without existing context on the project. labels May 30, 2022
@hdevalence
Copy link
Member Author

xref #1664

@hdevalence hdevalence mentioned this issue Nov 28, 2022
Closed
hdevalence added a commit that referenced this issue Nov 29, 2022
@hdevalence @conorsch
component: better test infrastructure
8894677 
Work towards #1664

Closes #853

This commit cleans up the IBC client test as an example case of the new API.

Along the way, we also clean up some other ergonomic pain points, notably
adding an `Arc<State>::try_begin_transaction()` method.

Co-Authored-By: Conor Schaefer <conor@penumbra.zone>
@hdevalence hdevalence mentioned this issue Nov 29, 2022
Merged
hdevalence added a commit that referenced this issue Nov 29, 2022
@hdevalence @conorsch
component: better test infrastructure
490f325 
Work towards #1664

Closes #853

This commit cleans up the IBC client test as an example case of the new API.

Along the way, we also clean up some other ergonomic pain points, notably
adding an `Arc<State>::try_begin_transaction()` method.

Co-Authored-By: "Conor Schaefer" <conor@penumbra.zone>
hdevalence added a commit that referenced this issue Nov 29, 2022
@hdevalence @conorsch
component: better test infrastructure
23eb86d 
Work towards #1664

Closes #853

This commit cleans up the IBC client test as an example case of the new API.

Along the way, we also clean up some other ergonomic pain points, notably
adding an `Arc<State>::try_begin_transaction()` method.

Co-Authored-By: "Conor Schaefer" <conor@penumbra.zone>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Effort: Easy good first issue A good issue for people without existing context on the project. help wanted Help on this issue is welcomed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

component: better test infrastructure penumbra-zone/penumbra
1 participant
@hdevalence