feat(pd): support real addrs in testnet generate #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
pd-validator-refactor
branch
from
a149dd7 to
1df1bd1
Compare
conorsch
force-pushed
the
pd-validator-refactor
branch
from
1df1bd1 to
3583780
Compare
conorsch
force-pushed
the
pd-validator-refactor
branch
from
3583780 to
f016d94
Compare
conorsch
force-pushed
the
pd-validator-refactor
branch
from
f016d94 to
b539fff
Compare
Removed the default RFC1918 addresses from the `pd testnet generate` logic. Added two new options: * --peer-address-template * --external-addresses The goal is to allow a node operator to pass in public IPv4 address information at the time of config generation, so the emitted config files are valid without further munging, particularly with respect to the `external_address` Tendermint advertises for its P2P service. This change unblocks a leaner deployment pipeline, where we actually use the results of the `pd testnet generate` output, as intended. Also: fix(pd) support urls in testnet join We were inadvertently dropping paths on URLs by prepending `/` to `Url.join` args, which caused the join operation to be performed on the base domain, ignoring any path. We didn't notice this because all our services had been on their own subdomains.
conorsch
force-pushed
the
pd-validator-refactor
branch
from
b539fff to
0fb560e
Compare
|
I've done some manual testing of the deploy logic, against an ad-hoc devnet, to ensure that these changes will work fine with existing deployments. These changes unblock simplifying the CI logic, but those changes will come in separately, in order to keep things rolling smoothly, and to aid in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the default RFC1918 addresses from the
pd testnet generatelogic. Added two new options:The goal is to allow a node operator to pass in public IPv4 address information at the time of config generation, so the emitted config files are valid without further munging, particularly with respect to the
external_addressTendermint advertises for its P2P service.This change unblocks a leaner deployment pipeline, where we actually use the results of the
pd testnet generateoutput, as intended.Also: fix(pd) support urls in testnet join
We were inadvertently dropping paths on URLs by prepending
/toUrl.joinargs, which caused the join operation to be performed on the base domain, ignoring any path. We didn't notice this because all our services had been on their own subdomains.