rework transaction EffectHash
#2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
EffectHashEffectHash
redshiftzero
force-pushed
the
effect-hash-part-2
branch
from
7f0b8dc to
8775065
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
EffectHashEffectHash
|
|
redshiftzero
force-pushed
the
effect-hash-part-2
branch
from
83f2408 to
227d1dd
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
cronokirby
reviewed
Aug 21, 2023
Comment on lines
+43
to
+44
| effect_hash = BLAKE2b-512(len(type_url) || type_url || proto_encode(proto)) | ||
| ``` |
There was a problem hiding this comment.
Might want to specify how the length is encoded
cronokirby
approved these changes
Aug 21, 2023
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Error
hdevalence
reviewed
Aug 21, 2023
Comment on lines
59
to
64
| let personalization = TransactionBody::TYPE_URL; | ||
|
|
||
| let mut state = blake2b_simd::State::new(); | ||
| let length = personalization.len() as u64; | ||
| state.update(&length.to_le_bytes()); | ||
| state.update(personalization.as_bytes()); |
There was a problem hiding this comment.
Can we factor this into a common method?
There was a problem hiding this comment.
Aesthetically I think it'd be nice if this used a u16 length for compactness but I'm not sure that that's actually a good idea. Probably best to not have to worry about the length.
There was a problem hiding this comment.
(Probably not important to block merging on this)
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2808
Adds a section of documentation on transaction signing which describe the changes made in this PR