docs: fix up key derivation chart #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
hdevalence
commented
Sep 5, 2023
| The root key material for a particular spend authority is the 32-byte | ||
| `seed` derived as above from the seed phrase. The `seed` value is used to derive | ||
| `spend_key_bytes` derived as above from the seed phrase. The `spend_key_bytes` value is used to derive |
There was a problem hiding this comment.
I changed this to eliminate references to seed; I think it's confusing since although it's the "seed" of the Penumbra-specific part of the key heirarchy, it's not necessarily the seed in the sense of the seed phrase (i.e., the ultimate root of capability).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves a TODO we should address as part of #2964