Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for all internal setup ceremony items #3005

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

cronokirby
Copy link
Contributor

@cronokirby cronokirby commented Sep 12, 2023

Closes #2877.

(also tweaks the API to make more things available, which I had forgotten).

Here's some benchmarks on my laptop (AMD Ryzen 7 6800HS):

Running benches/all.rs (/home/lucas/Work/Penumbra/Penumbra/target/release/deps/all-2e3abdec058d17d3)
Gnuplot not found, using plotters backend
Benchmarking phase 1: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 843.0s.
phase 1                 time:   [83.327 s 83.960 s 84.580 s]

Benchmarking phase 1 check: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 1562.9s.
phase 1 check           time:   [155.04 s 155.54 s 156.03 s]

Benchmarking phase transition: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 1476.2s.
phase transition        time:   [147.02 s 147.27 s 147.54 s]

Benchmarking phase 2: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 167.9s.
phase 2                 time:   [15.763 s 15.984 s 16.209 s]

phase 2 check           time:   [273.82 ms 276.81 ms 280.27 ms]

Might be a good idea to have someone with the same computer model as was used to run the other benchmarks to run these to have consistent numbers. (Maybe having a machine for running benchmarks might be a good idea?, dunno)

(aso tweaks the API to make more things available, which I had
forgotten).

Haven't run the benchmarks yet, maybe @redshiftzero you can run them on
your computer for consistency 8^)

Run rustfmt
@cronokirby cronokirby temporarily deployed to smoke-test September 12, 2023 16:45 — with GitHub Actions Inactive
@cronokirby cronokirby marked this pull request as ready for review September 12, 2023 17:15
@cronokirby cronokirby temporarily deployed to smoke-test September 12, 2023 17:15 — with GitHub Actions Inactive
@redshiftzero redshiftzero merged commit 578cb1a into main Sep 12, 2023
8 checks passed
@redshiftzero redshiftzero deleted the 2877-setup-ceremony-benchmarks branch September 12, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Ceremony: Implement benchmarks for contributions, log verification, etc.
2 participants