Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📌 fix(ci): pin nightly toolchain #3749

Merged
merged 1 commit into from
Feb 6, 2024
Merged

📌 fix(ci): pin nightly toolchain #3749

merged 1 commit into from
Feb 6, 2024

Conversation

cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Feb 6, 2024

this ci action fails due to tkaitchuck/aHash#200.

@cratelyn cratelyn added A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. labels Feb 6, 2024
@cratelyn cratelyn self-assigned this Feb 6, 2024
@cratelyn cratelyn marked this pull request as draft February 6, 2024 19:54
@cratelyn
Copy link
Contributor Author

cratelyn commented Feb 6, 2024

the rustdoc build script uses +nightly. we'll need to sort out how to thread that through from the github action for future nightly breakages like this.

@conorsch
Copy link
Contributor

conorsch commented Feb 6, 2024

Nice, thanks for jumping on this, I hadn't started debugging the nightly failure.

@cratelyn cratelyn mentioned this pull request Feb 6, 2024
Closed
@cratelyn
Copy link
Contributor Author

cratelyn commented Feb 6, 2024

Nice, thanks for jumping on this, I hadn't started debugging the nightly failure.

credit to tracking down the upstream issue goes to @erwanor 🥇

@conorsch conorsch force-pushed the katie/pin-rustdocs-nightly-toolchain branch from 5e8e889 to 7e47645 Compare February 6, 2024 20:27
@conorsch
Copy link
Contributor

conorsch commented Feb 6, 2024

the rustdoc build script uses +nightly

I patched the rust-docs build script to use nightly-2024-02-01 as a temporary workaround. Builds locally for me again, so CI should pass, too.

@conorsch conorsch marked this pull request as ready for review February 6, 2024 20:32
@conorsch conorsch self-requested a review February 6, 2024 20:32
@conorsch conorsch merged commit dfa3bba into main Feb 6, 2024
7 checks passed
@conorsch conorsch deleted the katie/pin-rustdocs-nightly-toolchain branch February 6, 2024 20:47
conorsch added a commit that referenced this pull request Feb 7, 2024
@conorsch
ci: fix docs build nightly version
7c4716e 
Refs #3750. Follow-up to #3749, which updated the per-PR CI workflow,
but not the deploy-on-merge-to-main workflow.
@conorsch conorsch mentioned this pull request Feb 7, 2024
Merged
conorsch added a commit that referenced this pull request Feb 7, 2024
@conorsch
ci: fix docs build nightly version
74da90d 
Refs #3750. Follow-up to #3749, which updated the per-PR CI workflow,
but not the deploy-on-merge-to-main workflow.
TalDerei pushed a commit that referenced this pull request Feb 8, 2024
@conorsch @TalDerei
ci: fix docs build nightly version
9cf97b6 
Refs #3750. Follow-up to #3749, which updated the per-PR CI workflow,
but not the deploy-on-merge-to-main workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch Awaiting requested review from conorsch

Assignees

@cratelyn cratelyn

Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @conorsch