Port v0.80.0 changes to main branch #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `logic_version` flag to withdrawals, to allow issuing compat address withdrawals. It also implements correct error handling on withdrawal attemtps when counterparty chains return an error. (cherry picked from commit b49d69d)
(cherry picked from commit d3d1ecf)
(cherry picked from commit 3daac04)
(cherry picked from commit 0c0ca04)
This commit adds a pd migration, intended to permit upgrade coordination, so that breaking changes related to ibc withdrawal handling can be made to pd safely. The migration doesn't alter chain state: it simply flips the halt bit off, and permits the chain to resume, after folks have upgraded to a new version of pd. This approach assumes that an upgrade proposal was submitted and passed, in order to halt the chain in a coordinated upgrade. chore: bump crate versions to 0.80.0-alpha.1 (cherry picked from commit 2c89729)
This adds a state change to the migration, in order to replace all of the packets which had error acknowledgements, so that, post-migration, the acks can be replayed with the correct logic for error acks, the packets having been replaced in the state. This also changes the IBC component visibility of a trait to reuse the logic for inserting packet commitments. (cherry picked from commit 09a822e)
(cherry picked from commit 0481d9e)
(cherry picked from commit 69dd56a)
(cherry picked from commit f8fd4b4)
conorsch
added
consensus-breaking
cronokirby
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR cherry-picks all the commits from #4787, constituting
v0.80.0, back into themainbranch. It's necessary to do so, because the changes in #4787 were prepared against a release branch,release/v0.80.x, which was branched off of thev0.79.3tag, to ensure the smallest possible diff.Given that these changes are critical, let's get them into the main branch, so that regular development workflows will use them going forward.
Issue ticket number and link
Refs #4787.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Reviewing
The reviewer should ensure that this PR includes all of, and nothing but, the commits present in #4787.