Pindexer remove unused appviews #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was initially just an example, of which we have much better ones now.
|
SGTM |
Where? If we know for sure, some proactive outreach might be warranted. Also happy to just leave it in place if you are. |
conorsch
approved these changes
Oct 30, 2024
|
https://github.com/radiantcommons/penumbra-token-info uses it ; should be a very simple change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This removes:
The Dex AppView shouldn't be needed, given that we have an app view specific to the dex explorer now.
The shielded pool app view was just an example, which can be removed given the many other examples now.
Other AppViews which should be removed in a later PR after making sure they're not used:
Testing
The other app views should continue to work.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: