Input #8
Merged
Input #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2018 23:59
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 100% 61.42% -38.58%
===========================================
Files 9 13 +4
Lines 43 70 +27
Branches 10 14 +4
===========================================
Hits 43 43
- Misses 0 23 +23
- Partials 0 4 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 13 +4
Lines 43 56 +13
Branches 10 15 +5
=====================================
+ Hits 43 56 +13
Continue to review full report at Codecov.
|
added 24 commits
January 9, 2019 19:20
penx
commented
Jan 16, 2019
| @@ -0,0 +1,6 @@ | |||
| const { toHaveNoViolations } = require('jest-axe'); | |||
| const { setRender } = require('govuk-frontend-template-spec/lib/jest-helpers'); | |||
There was a problem hiding this comment.
setRender should be exported from govuk-frontend-template-spec root
added 10 commits
January 18, 2019 13:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govuk-frontendviagovuk-frontend-template-specNote: At the moment, Jest snapshots are manually copied across. When Jest 0.24 comes out there will be a feature to allow the snapshot test location to be configured (jestjs/jest#6143), so will keep the manual process for now, with the aim to load them in from node_modules when 0.24 is out.