-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flake8 settings from setup.cfg #95
Comments
Hello @datapythonista ! Thank you so much for the wonderful suggestion. A new release of the app has been pushed, tested and deployed with your suggestion. You can now remove the |
thanks @OrkoHunter, I created this issue in pandas, will let you know how it works: pandas-dev/pandas#25605 thank you! |
Now, pep8speaks seem to ignore flake8 configurations in |
pep8speaks allows setting up flake8 parameters using the config option
pycodestyle
. For example:https://github.com/pandas-dev/pandas/blob/master/.pep8speaks.yml#L8
But Python projects/flake8 already defines a way to specify those, which is in the
flake8
section ofsetup.cfg
. For example:https://github.com/pandas-dev/pandas/blob/master/setup.cfg#L14
I think it'd be nice to keep the
pycodestyle
setting, but in case it's not present, it should look for the options insetup.cfg
and use them. This way, projects don't need to maintain two different copies of the flake8 settings, and there are no mismatches in the errors the pep8speaks reports, and what the CI of the projects are linting.The text was updated successfully, but these errors were encountered: