Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify pep8 speaks #5607

Merged
merged 5 commits into from
Jan 24, 2021
Merged

unify pep8 speaks #5607

merged 5 commits into from
Jan 24, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 21, 2021

What does this PR do?

pycodestyle: this is dropped in favor od unified config
see: pep8speaks-org/pep8speaks#95 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Jan 21, 2021
@Borda Borda requested a review from tchaton as a code owner January 21, 2021 20:39
@Borda Borda added this to the 1.1.x milestone Jan 21, 2021
@Borda Borda self-assigned this Jan 21, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

We don't need to leave those 2 comments

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #5607 (83b7cf5) into master (96cdca1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5607   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10005   10005           
======================================
  Hits         9340    9340           
  Misses        665     665           

@Borda Borda added the ready PRs ready to be merged label Jan 21, 2021
@mergify mergify bot requested a review from a team January 21, 2021 22:09
@mergify mergify bot requested a review from a team January 22, 2021 02:44
@tchaton tchaton disabled auto-merge January 24, 2021 09:39
@tchaton tchaton enabled auto-merge (squash) January 24, 2021 09:39
@tchaton tchaton merged commit f094e10 into master Jan 24, 2021
@tchaton tchaton deleted the ci/pep8 branch January 24, 2021 14:01
tchaton pushed a commit that referenced this pull request Feb 3, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
tchaton pushed a commit that referenced this pull request Feb 4, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 4, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants