[WIP][追加課題]タスクにメモ機能の追加 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udzura
reviewed
Oct 18, 2016
|
|
||
| create_table "tasks", force: :cascade do |t| | ||
| t.text "content" | ||
| t.integer "status", limit: 4 | ||
| t.date "duedate" | ||
| t.text "memo" |
There was a problem hiding this comment.
Rails側のマイグレーションファイルがないですが、どこに行きましたか...
There was a problem hiding this comment.
udzura
reviewed
Oct 18, 2016
| @@ -1 +1 @@ | |||
| json.extract! @task, :id, :content, :status | |||
| json.extract! @task, :id, :content, :status :memo | |||
udzura
reviewed
Oct 18, 2016
| @@ -1,11 +1,23 @@ | |||
| import React from "react"; | |||
| import ReactDOM from "react-dom"; | |||
|
|
|||
| export default class Task extends React.Component { | |||
| handleUpdate(e) { | |||
| e.preventDefault(); | |||
| this.props.onTaskUpdate({task: {id: this.props.id, status: e.target.value}}); | |||
There was a problem hiding this comment.
onTaskUpdateってtaskにすべての属性を渡さなくていいんでしたっけ。どこが本体だったかな...
There was a problem hiding this comment.
takapi-todo-app/app/assets/javascripts/TaskApp.js
Lines 46 to 58 in efddbb4
ここですね（下も同じ）
PATCHのエントリポイントが部分的な更新を取り扱えるはずだからOKそう
udzura
approved these changes
Oct 18, 2016
|
|
||
| create_table "tasks", force: :cascade do |t| | ||
| t.text "content" | ||
| t.integer "status", limit: 4 | ||
| t.date "duedate" | ||
| t.text "memo" |
There was a problem hiding this comment.
|
|
udzura
approved these changes
Oct 18, 2016
| @@ -7,9 +7,6 @@ | |||
| require 'rspec/rails' | |||
| # Add additional requires below this line. Rails is not loaded until this point! | |||
|
|
|||
| # for sqlite3 use in memory | |||
| load Rails.root.join('db/schema.rb') if ENV['CI'] | |||
There was a problem hiding this comment.
あるいはここの前に ActiveRecord::Base.establish_connection するといいのかもしれない。ちょっと深追いできてないけど...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装内容
動作
やりたいこと