Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memo structure for TX PVLS #580

Merged
merged 7 commits into from
Dec 16, 2022
Merged

Update memo structure for TX PVLS #580

merged 7 commits into from
Dec 16, 2022

Conversation

jason-p-pickering
Copy link
Contributor

Developer:

Summary of Proposed Changes

Related Issues

  • DP-XXX
  • etc.

Reviewer:

  • Tests added/updated & passing.
  • Clean linting.
  • Related issue ticket in Jira/GitHub.
  • Documentation added/updated.
  • Code conforms to style guidelines.
  • Well commented.
  • Updates reflected in NEWS.md.
  • Build check passes.

@JordanBalesBAO JordanBalesBAO merged commit ecb9f59 into master Dec 16, 2022
@JordanBalesBAO JordanBalesBAO deleted the DP-838 branch December 16, 2022 16:28
jason-p-pickering added a commit that referenced this pull request Jan 20, 2023
* HOT FIX Update memo structure for TX PVLS (#580)

* Update memo structure for TX PVLS

* Fix memo structure

* Fix partners table

* Fix partners table

* Fix failing tests

* Linting

* updated description and news file for quick release

Co-authored-by: Jordan <Jordan>

* Standardize d

Co-authored-by: Jason Pickering <jason.p.pickering@gmail.com>
jacksonsj added a commit that referenced this pull request Jan 24, 2023
* DP-793 Update Cascade Workflow

Begin work to reshuffle COP23 Cascade tab to resemble COP21 template

* DP-788

Template with Year 2 Target tab

* DP-788

Alpha Pack template work

* DP-788

Alpha pack, getting ride of external file link

* DP-788

delete external formula reference

* DP-788

- HTS tab HTS Modality consolidaiton
- move PrEP tab after KP tab
- Move TX_NEW on Cascade tab

* DP-788

HTS tab:
- modalities collapse
- HTS_Recent move
Year 2 target tab

* DP-788

Year 2 Targets Tabs

* DP-788

PrEP_CT HTS change

* DP-793

Cascade flow work

* Create COP23_Data_Pack_Template_YR2 Targets_sjj.xlsx

Updates to Cascade Workflow (DP-793)
Updates to color scheme on Cascade tab (DP-806)

* Complete DP-806

* Updates to PMTCT, TB, VMMC, EID, HTS

* Minor formula typos on Cascade tab

* DP-788

CXCA Calcualtion changes
HTS tab
Cascade tab expected achievement

* DP-788

FY Updates
Color to Targets

* DP-788

FY Updated across all tabs

* DP-788

Color added to all Target cells

* DP-788

PrEP_CT to HTS tab
HTS tab formulas, and hyperlinks

* DP-793

FY24 ART Coverage rate

* DP-788

OVC Tab updates
Hyperlink fixes

* DP-788

Target Indicators color

* DP-788

VMMC POS and NEG

* DP-788

Template version as of Nov 9
HTS tab

* DP-788

* DP-793

Cascade tab move expected acheivement, add metadata

* DP-788

HTS tab changes for VMMC and PrEP HTS_TST
Target column color change
PrEP NEW and CT formula change

* DP-788

KP Validation age bands

* DP-788

KP Validation and AGYW

* DP-788

* DP-788

TB_PREV (D)

* Updates to Home, Spectrum, Prioritization Tabs

- Home: Rename to TST
- Spectrum: Update colors. Update ID fx to ref "CY2022Q4" instead of 2021.
- Prioritization: Remove SNU1 col. Update FYs.

* Clean up old COP23 template files

* Updates on Cascade, EID, PMTCT, TB, VMMC

Cascade:
- Update label of TX_CURR Expected Achievement (FY23)
- Update TX_NET_NEW (FY23) to use Expected Achievement instead of FY23 target for TX_CURR.
- Clarify labels for Host Country Cascade
- Make all Host Country Cascade editable (even percentages & FY24 PLHIV)
- Note target columns in row 2 instead of with colors (ADA happier)
- Fix formula references to EID tab.
- Update calendar year references in Host Country Cascade INDEX formulas

EID
- Update labels

PMTCT
- Update CY references in Spectrum formulas
- Updated formula for PMTCT_STAT (D) (FY24) to pull only from PEPFAR data instead of take min of PEPFAR, Host Country (less opaque to understand)
- Update labels.

TB:
- Update labels
- Update CY references in Spectrum formulas

VMMC:
- Update CY references in Spectrum formulas.
- Update labels.

* Update COP23_Data_Pack_Template.xlsx

Updates to formulas, labels, etc. on all tabs to align

* First steps to create COP23 Data Pack schema

* Create update_cop23_datapack_schema.R

* DP-788

AGYW tab reference columns

* DP-788

TX_TB_PREV target indicator color
Year 2 target formula

* DP-788

all DSD and TA reviewed and updated for FY24 and FY23

* DP-788

HTS_Index and other row 10 updates and review

* DP-788: Validation of all rows 1-3, 5-14

* Cleanup/archive in inst/extdata

* Data Pack Template: Update/confirm all row 5-15

* Update update_cached_map_datapack_cogs.R

* Update getCurrentCOPYear

* Archive COP23 categoryOptionGroups & COGS

* Create COP 2023 categoryOptionGroups.json

* Update packageSetup for COP23

* Accommodate COP23 tool name change to "Target Setting Tool"

* Reorganize/Clean up data-raw

* Create method for caching data pack groupings

* Create cop23_data_pack_schema.rda

* Create cop_datapack_countries.rda

* Update datapack_cogs.rda

* COP23 DP Template: Change tab colors to no color

* DP-832

* Update tests

* Update conditional formatting. Add PrEP_CT testing dataElements & CO

* Update cop23_data_pack_schema with new PrEP_CT testing DEs & COs

* Documentation not updated from dev

* Add new dataSet IDs just created

* Update vali_OrgUnits to reflect temporary test change in PSNU level for Malawi & Zim

* Update list of countries for Beta Pack generation

* Hide ID col on all tabs

* Delete copy file

* Make sure DSNUs only print to AGYW tab

* DP-809 in exportPackr/packTool

* Fix DP-836

* Fix issues with file naming

* Fix some failing tests

* Update COP23_Data_Pack_Template.xlsx

- Add Prioritization formula to each tab
- Confirm/Add all subtotal functions

* Update COP23_Data_Pack_Template.xlsx

- More formatting (bold, conditional formatting)

* Update COP23_Data_Pack_Template.xlsx

Finalized conditional formatting across all tabs except TX_TB_PREV & OVC

* Update COP23_Data_Pack_Template.xlsx

Fixes/confirmation on numeric & percentage formats

* Update COP23_Data_Pack_Template.xlsx

Finalize TX_TB_PREV tab
Revise Year 2 tab

* Fix some test failures

* Update COP23_Data_Pack_Template.xlsx

- Year 2 tab overhaul

* Additional updates to Year 2 tab

- dataElements
- Formula changes to hide if 0

* HOT FIX Update memo structure for TX PVLS (#580)

* Update memo structure for TX PVLS

* Fix memo structure

* Fix partners table

* Fix partners table

* Fix failing tests

* Linting

* updated description and news file for quick release

Co-authored-by: Jordan <Jordan>

* Add Y2 ages for all indicators. Split TX_TB, TB_PREV, & OVC into column disaggs

* Add DATIM metadata for OVC, TX_TB, TB_PREV to Y2 tab

* Update COP23_Data_Pack_Template.xlsx

- Make # PrEP tests editable
- Change host country to partner country in labels
- Corrected formulas in Cascade for P.C. # on ART, & P.C. # VLS
- Add PLHIV_Attend.T_1 & Untreated_PLHIV_Attend.T_1

* Update COP23_Data_Pack_Template.xlsx

Update formulas to pull from Spectrum for PLHIV_Attend.T_1, Untreated_PLHIV_Attend.T_1, PLHIV.T, NEW_INFECTIONS_SUBNAT.T2, & PLHIV.T2

* Update COP23_Data_Pack_Template.xlsx

- Add KP ART Coverage to KP tab
- Add PMTCT_ART to Year 2 tab
- Add TB_ART to Year 2 tab
- Add OVC_HIVSTAT to Year 2 tab

* Update COP23_Data_Pack_Template.xlsx

- Correct suffixes for OVC_HIVSTAT from T to T2

* Update cop23_data_pack_schema.rda

Based on latest template changes

* Update update_cop23_datapack_schema.R

* Update test scripts

* Update COP23_Data_Pack_Template.xlsx

- Make sure gridlines not shown on Home tab
- Make sure all panes frozen correctly on each tab
- Correct formula for VL_TESTING_SUBNAT.T on Cascade
- Correct formulas on Year 2 tab
- Adjust color coding on Year 2 tab

* Update cop23_data_pack_schema.rda

update to reflect latest changes to template

* Update COP23_Data_Pack_Template.xlsx

Adjust formulas on HTS for PMTCT & VMMC to not show if Male, or Female, respectively.

* Update cop23_data_pack_schema.rda

* Update styleGuide with new Home Tab colors

* Ready packing scripts for COP23

* Move createDataPack to own file

* Add unpack parameter to unPackSheets

* Dp 719: Generate COP23 test data (#579)

* Update HTS modalities for COP23

* Add script for generation of COP23 test data

* Remove unneeded file

* Update mock data script for COP23

* feat: Introduce function for getting a valid organisation units by COP Year (#582)

* (Revert) Updates to tests

Update logic in packing checks

* fix checkDisaggs test

- fix test for checkDisaggs

* fix test-packdatapack and lint

- linted and fixed test-packDatapack

* Revert changes to tests

* Introduce getValidOrgunits based on COP Year

* fix test to pass

fixed packTool code to pass test

* Re-enable test for defunct disaggs

Co-authored-by: Fausto Lopez <flopez@baosystems.com>

* Add data sets for COP23

* Fix test

* Linting

* Update news

* Remove deprecation warnings

* Remove various print statements

* Add tests for generating COP23 datapacks

* Add test back for COP22 prioritizations

Co-authored-by: Christian Domaas <61550159+christian-domaas@users.noreply.github.com>
Co-authored-by: Jason Pickering <jason.p.pickering@gmail.com>
Co-authored-by: Jordan Bales <89547800+JordanBalesBAO@users.noreply.github.com>
Co-authored-by: Fausto Lopez <flopez@baosystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants