Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when checkingAnalytics with only PSNUxIM tools #655

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix bug when checkingAnalytics with only PSNUxIM tools #655

merged 1 commit into from
Apr 4, 2023

Conversation

jason-p-pickering
Copy link
Contributor

Developer:

Summary of Proposed Changes

  • checkAnalytics (and the app) will fail if users run ONLY a PSNUxIM tool through the app due to missing required sheets. This situation does not happen with a TST+PSNU combo, but better to fix it just in case.

Related Issues

Reviewer:

  • Tests added/updated & passing.
  • Clean linting.
  • Related issue ticket in Jira/GitHub.
  • Documentation added/updated.
  • Code conforms to style guidelines.
  • Well commented.
  • Updates reflected in NEWS.md.
  • Build check passes.

@JordanBalesBAO JordanBalesBAO merged commit 59d884e into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanBalesBAO JordanBalesBAO Awaiting requested review from JordanBalesBAO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-p-pickering @JordanBalesBAO