Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with blank DP targets in unPackSNUxIM #701

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix issue with blank DP targets in unPackSNUxIM #701

merged 1 commit into from
May 24, 2023

Conversation

jason-p-pickering
Copy link
Contributor

Developer:

Summary of Proposed Changes

  • When values in the PSNUxIM tab were blank (but not in the main tabs), these rows were not being properly flagged by the non-equal test code.

Related Issues

  • DP-1041
  • etc.

Reviewer:

  • Tests added/updated & passing.
  • Clean linting.
  • Related issue ticket in Jira/GitHub.
  • Documentation added/updated.
  • Code conforms to style guidelines.
  • Well commented.
  • Updates reflected in NEWS.md.
  • Build check passes.

@jason-p-pickering jason-p-pickering merged commit c665122 into master May 24, 2023
@jason-p-pickering jason-p-pickering deleted the DP-1041 branch May 24, 2023 13:50
@JordanBalesBAO
Copy link
Collaborator

can you put this in dev as well please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanBalesBAO JordanBalesBAO JordanBalesBAO approved these changes

@flopez-bao flopez-bao flopez-bao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-p-pickering @JordanBalesBAO @flopez-bao