Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirement for ngstk #320

Closed
nsheff opened this issue Jun 21, 2019 · 6 comments
Closed

requirement for ngstk #320

nsheff opened this issue Jun 21, 2019 · 6 comments

Comments

@nsheff
Copy link
Contributor

nsheff commented Jun 21, 2019

it seems that peppy has introduced a dependency on ngstk.

but there is no ngstk on pypi that solve the requirement:

Could not find a version that satisfies the requirement ngstk (from peppy>=0.19.1->geofetch==0.6.0.dev0) (from versions: 0.0.1rc0, 0.0.1rc1, 0.0.1rc2)

I think it's because the version of ngstk on pypy is listed as rc? I am not sure here.

I think we need to:

  1. release an actual release version of ngstk on pypi;

  2. it seems like peppy should not rely on ngstk. can't remember if we've discussed this before...

@nsheff
Copy link
Contributor Author

nsheff commented Jun 21, 2019

for example, try to install peppy in a clean virtualenv:

virtualenv activate
New python executable in /home/sheffien/blah/activate/bin/python
Installing setuptools, pip, wheel...done.
sheffien@nox:~/blah$ pip install peppy
Downloading/unpacking peppy
  Downloading peppy-0.22.1.tar.gz
  Running setup.py (path:/tmp/pip_build_sheffien/peppy/setup.py) egg_info for package peppy
    Warning: pandoc conversion failed!
    /tmp/pip_build_sheffien/peppy/setup.py:12: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
      deps = []
    warning: no files found matching 'peppy/submit_templates/*'
Requirement already satisfied (use --upgrade to upgrade): attmap>=0.12.5 in /home/sheffien/.local/lib/python3.4/site-packages (from peppy)
Requirement already satisfied (use --upgrade to upgrade): pandas>=0.20.2 in /home/sheffien/.local/lib/python3.4/site-packages (from peppy)
Requirement already satisfied (use --upgrade to upgrade): pyyaml>=5 in /home/sheffien/.local/lib/python3.4/site-packages (from peppy)
Downloading/unpacking divvy>=0.3.2 (from peppy)
  Downloading divvy-0.3.3.tar.gz
  Running setup.py (path:/tmp/pip_build_sheffien/divvy/setup.py) egg_info for package divvy
    /tmp/pip_build_sheffien/divvy/setup.py:12: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
      # Ordinary dependencies
Requirement already satisfied (use --upgrade to upgrade): logmuse>=0.2 in /home/sheffien/.local/lib/python3.4/site-packages (from peppy)
Requirement already satisfied (use --upgrade to upgrade): ubiquerg>=0.4.3 in /home/sheffien/.local/lib/python3.4/site-packages (from peppy)
Downloading/unpacking ngstk (from peppy)
  Could not find a version that satisfies the requirement ngstk (from peppy) (from versions: 0.0.1rc0, 0.0.1rc1, 0.0.1rc2)
Cleaning up...
No distributions matching the version for ngstk (from peppy)
Storing debug log for failure in /home/sheffien/.pip/pip.log

how is this passing tests on travis? I don't understand...

@vreuter
Copy link
Member

vreuter commented Jun 21, 2019

ngstk isn't released for python3.4, which it looks like you're using.

@nsheff
Copy link
Contributor Author

nsheff commented Jun 21, 2019

You nailed it! Let's not worry about python 3.4...

@vreuter
Copy link
Member

vreuter commented Jun 21, 2019

That said, I'm not sure why it's in the requirements in the first place--I see no usage of it on dev

@nsheff nsheff closed this as completed Jun 21, 2019
@nsheff
Copy link
Contributor Author

nsheff commented Jun 21, 2019

I think it may be a relic of some earlier refactoring, that eventually ended up in ubiquerg. if we can remove it that would be great, because my 7-year-old computer at home is still running ubuntu-version-ancient, and python 3.4 is the standard install... so I can't run stuff on it :)

@nsheff
Copy link
Contributor Author

nsheff commented Jun 21, 2019

it's also not used on master. let's just take it out.

vreuter added a commit that referenced this issue Jun 21, 2019
vreuter added a commit that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants