-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove credential status from Status Attestation error #85
Comments
The actual response HTTP Status Codes do not provide any feedback on the Status Attestation status but only the request status, this is a proper behavior. From the other side for each request, the Status Assertion Error object includes the following list of possible Error Codes:
The invalid_request is described as "The request is not valid due to the lack or incorrectness of one or more parameters" and requires details in the error_description field: this looks overlapping with 'unsupported_hash_alg' and with 'invalid_request_signature' errors as they represent incorrectness in the relative parameters ( as in the invalid_request case). The credential_updated response brings potential issues from several aspects:
My suggestion here is:
|
Since we use multiple requests within a single array (json object) and obtain array of status assertion responses, we have decided to not use a single http status code describing the status of the response, since clientA may ask 3 status assertions about 3 different credentials, and obtain 2 status assertions and one status assertion error object within the response array. @fmarino-ipzs worked a lot in this field, if is there something else to say it would be great to get his perspective too. |
In relation to the discussion in #61, the Status Attestation error values should not contain the credential status. The status of the credential, it being revoked, suspended or invalid, should not be considered an Status Attestation error.
The text needs to be revised to remove all mention of using errors for this purpose.
The text was updated successfully, but these errors were encountered: