-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features for custom job/scheduler running times #29
Merged
Commits on Mar 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4434e60 - Browse repository at this point
Copy the full SHA 4434e60View commit details
Commits on Apr 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 8ca3c33 - Browse repository at this point
Copy the full SHA 8ca3c33View commit details
Commits on Apr 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3f19a72 - Browse repository at this point
Copy the full SHA 3f19a72View commit details
Commits on Apr 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 62a9b54 - Browse repository at this point
Copy the full SHA 62a9b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf78ec - Browse repository at this point
Copy the full SHA dbf78ecView commit details
Commits on Apr 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 204b422 - Browse repository at this point
Copy the full SHA 204b422View commit details -
Configuration menu - View commit details
-
Copy full SHA for c792daa - Browse repository at this point
Copy the full SHA c792daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a47472b - Browse repository at this point
Copy the full SHA a47472bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0e1c8b - Browse repository at this point
Copy the full SHA d0e1c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce38f9 - Browse repository at this point
Copy the full SHA 3ce38f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 497d58b - Browse repository at this point
Copy the full SHA 497d58bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b68f3 - Browse repository at this point
Copy the full SHA 56b68f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc4d4a9 - Browse repository at this point
Copy the full SHA dc4d4a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3361e91 - Browse repository at this point
Copy the full SHA 3361e91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f398a3 - Browse repository at this point
Copy the full SHA 0f398a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 091a1e0 - Browse repository at this point
Copy the full SHA 091a1e0View commit details
Commits on Apr 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 2a8deba - Browse repository at this point
Copy the full SHA 2a8debaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c208b68 - Browse repository at this point
Copy the full SHA c208b68View commit details -
Using an older version of phpunit to allow testing on php5, as phpunit v6 requires php7
Configuration menu - View commit details
-
Copy full SHA for fc10754 - Browse repository at this point
Copy the full SHA fc10754View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ecb2de - Browse repository at this point
Copy the full SHA 5ecb2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6210b3f - Browse repository at this point
Copy the full SHA 6210b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fd8c95 - Browse repository at this point
Copy the full SHA 9fd8c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee760a - Browse repository at this point
Copy the full SHA 7ee760aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 406fb0e - Browse repository at this point
Copy the full SHA 406fb0eView commit details
Commits on Apr 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1aa485c - Browse repository at this point
Copy the full SHA 1aa485cView commit details
Commits on Apr 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 08abf9f - Browse repository at this point
Copy the full SHA 08abf9fView commit details
Commits on Jul 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 6faa1de - Browse repository at this point
Copy the full SHA 6faa1deView commit details -
Added support for SwiftMailer ^6.0 ::newInstance() method has been deprecated, along with Swift_MailTransport. The default mail transport is now sendmail when using swiftmailer https://legalhackers.com/advisories/SwiftMailer-Exploit-Remote-Code-Exec -CVE-2016-10074-Vuln.html
Configuration menu - View commit details
-
Copy full SHA for c086719 - Browse repository at this point
Copy the full SHA c086719View commit details
Commits on Aug 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f5b2a97 - Browse repository at this point
Copy the full SHA f5b2a97View commit details
Commits on Aug 10, 2017
-
Implementation of #23 using
then
methodSimilar implementation of the PR #23 submitted by @badyto Reused the same tests on that PR There is also a possible breaking change with the output passed to the callback in the `then` method, when executing a script the output will be now an array instead of a string.
Configuration menu - View commit details
-
Copy full SHA for 77e2e95 - Browse repository at this point
Copy the full SHA 77e2e95View commit details
Commits on Aug 26, 2017
-
This test ensures that if a job is delayed by e.g. a previous job, it will run if it was due when the scheduler ran.
Configuration menu - View commit details
-
Copy full SHA for c5eb1a1 - Browse repository at this point
Copy the full SHA c5eb1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8337c6 - Browse repository at this point
Copy the full SHA b8337c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eafcf5 - Browse repository at this point
Copy the full SHA 2eafcf5View commit details
Commits on Sep 1, 2017
-
Allow run() to be executed multiple times (#24)
* Allow run() to be executed multiple times The current code expects the run() to be called only once. This is fine if you start the scheduler from cron each minute and re-initialize it each time. If you want to manually run the scheduler, or maybe have a lot of jobs you do not want to init each minute, it would be useful to call run() multiple times in the lifetime of the scheduler. In this case the collected data of the last run should be reset. the executedJobs, failedJobs and outputSchedule. * Allow queued jobs to be removed If the scheduler is used to do multiple runs then it would be useful to reset all queued Jobs. Currently the only way to do this is by re-creating the scheduler object. But if the object is injected in the code then this is not practical.. * Fix StyleCI analysis failure Comment format fixed. * Allow run() to be executed multiple times After discussion with @peppeocchi make the re-running manually triggered. So added a resetRun() method which can be called before each run(). Also adjusted the test for this. * Allow run() to be executed multiple times The isDue check on the jobs is not provided a datetime in the run() method. This means they use the creation time of the job as the 'current' time to compare against. Most likely this creation time is approx the time run() is called so normally this is no problem. But if setting up the job schedule takes more time then I would say, using the creation time as run time is unexpected. And if you run run() multiple times then it will always run the same jobs because the time never changes. So now provide an explicit run time for all jobs, which is the same for all jobs each run. * Fix StyleCI analysis failure Remove empty line
Configuration menu - View commit details
-
Copy full SHA for f8374af - Browse repository at this point
Copy the full SHA f8374afView commit details
Commits on Sep 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9d55b27 - Browse repository at this point
Copy the full SHA 9d55b27View commit details -
Allow run() to run at arbitrary time (#28)
Currently when run() is called it uses the current time as the run timestamp. However it would be useful to run the scheduler at a specific time. So allow an optional param with a DateTime to run(). Reasons for running at a specific time other than now() could be: - Catching up on 'missed' runs, eg. when the system was down. - Making sure the scheduler runs at an intended timestamp eg. when cron is started at midnight it could be slow and start the php process only at 00:01 and thus missing all midnight schedules. - Improve testability of the scheduler (fake the time)
Configuration menu - View commit details
-
Copy full SHA for 72a20d9 - Browse repository at this point
Copy the full SHA 72a20d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aa51f2 - Browse repository at this point
Copy the full SHA 1aa51f2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.