Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional statistics for Redis queries. #208

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

yole
Copy link
Contributor

@yole yole commented May 10, 2015

If config.redis.analyze_performance is enabled, log the
number and types of Redis queries executed on each
request.

If config.redis.analyze_performance is enabled, log the
number and types of Redis queries executed on each
request.
@epicmonkey
Copy link
Member

Let's discuss, i.e. there are external tools that can gather pretty much the same stats using either INFO or MONITOR redis commands. For example: https://github.com/facebookarchive/redis-faina

@yole
Copy link
Contributor Author

yole commented May 11, 2015

Do you know of any external tool which can correlate the stats with the URL being requested? It's not interesting for me to simply see how many operations of a certain kind we're performing in total - I need to see the statistics per request, and separately for each kind of request.

@epicmonkey
Copy link
Member

Personally, I do not know any other tools other than faina. Though my feelings are it could be extracted from the application to express middleware (./lib folder or whatever).

@epicmonkey
Copy link
Member

Ultimately, we must not confuse two things: 1) log/monitor queries (application), and 2) analyze performance on top of it (middleware).

@yole
Copy link
Contributor Author

yole commented May 12, 2015

If you prefer, I can extract the logic to a more isolated component.

@epicmonkey
Copy link
Member

That would be fantastic! BTW, I may be wrong when I said that "performance" is going to be a middleware. Up to you though.

davidmz pushed a commit to davidmz/freefeed-server-pepyatka that referenced this pull request May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants