Bump requirements python3.8 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torchmetrics 0.8 has removed support for versions of Pytorch-Lightning lower than v1.5 (#788)
The argument was remove in torchmetrics v0.9. Keep the argument in __init__ for backward compatibility only.
|
Hi Camila, thank you for looking into this! Indeed, pytorch-lightning & co dependencies have been quite tricky due to their many changes since the start of this project. The problem with simply relaxing the constraints is that many of pytorch lightning's features and methods have been moved around or deprecated, and the library needs to be able to perform inference as well as training (which fails under the relaxed constraints). I'll look into this shortly to try and work around some of the pl deprecations |
|
I wasn't able to commit in this PR, so I've moved some of your work to #16 to solve some compatibility issues with pytorch-lightning v2 mostly. |
|
I close this PR because the discussion has been moved to #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump requirements to be compatible with python 3.8
Hi @percevalw,
We would like to integrate a NER operation in medkit using the model developed in this paper: Privacy-preserving mimic models for clinical named entity recognition in French
We have developed the operation, but we have found some issues with the requirements of nlstruct v0.1.
I made this PR with the suggested versions of
torchmetrics,pytorch_lightningand others.For info, these packages have removed support for Python <= 3.7 in the latest versions.
I have tested the operation in inference, and it works fine.
Please let me know what you think about this PR.