Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix race condition when channel is closed and there is an attempt to read channel #37

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

Trying to fix race condition when channel is closed and there is an attempt to read channel #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,14 @@ func (c *Conn) SendCommand(ctx context.Context, cmd command.Command) (*RawRespon
c.responseChanMutex.RLock()
defer c.responseChanMutex.RUnlock()
select {
case response := <-c.responseChannels[TypeReply]:
if response == nil {
case response, ok := <-c.responseChannels[TypeReply]:
if !ok || response == nil {
// We only get nil here if the channel is closed
return nil, errors.New("connection closed")
}
return response, nil
case response := <-c.responseChannels[TypeAPIResponse]:
if response == nil {
case response, ok := <-c.responseChannels[TypeAPIResponse]:
if !ok || response == nil {
// We only get nil here if the channel is closed
return nil, errors.New("connection closed")
}
Expand Down