-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for issue #41 #42
base: master
Are you sure you want to change the base?
Conversation
Thanks for you patch @dalgard . Before I'm able to merge it, could you please add some tests around it? |
Can you see my two latest commits under this pull request? I don't know how to write the code around the call to |
You could take a look at |
Sorry for the late reply. It's a sound attitude, but this library doesn't have the greatest test coverage to begin with and the change is very little – I don't know how to write Tinytests, but with my scaffolding, it will take you very little time. At any rate, I'm using the patch in production – I really think you should consider it :) Thanks! |
…nced-cron Conflicts: synced-cron-server.js synced-cron-tests.js
In attempting to use the parser.cron method with this forked version, I am experiencing recursive calls during the execution stage of a scheduled job. With a CRON syntax input such as "58 13 30 4 ? 2015", I am experiencing these results: SyncedCron.add({
name: 'Crunch some important numbers for the marketing department',
schedule: function(parser) {
// parser is a later.parse object
return parser.cron('58 13 30 4 ? 2015');
},
job: function() {
/* Anything placed here is firing recursively */
}
}); What methods for parsing the later.js object have you been successful with in your fork @dalgard? Thanks! |
I don't really know the cron syntax, I'm using this line in my application: // Non-recurring
return parser.recur().on(ending_at).fullDate(); |
#41