-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product: First and last products should have larger adjacent images #6
Comments
You'll see the parent div ( |
We need to be able to change out the image so it doesn't load the lower quality asset. |
Looks good! |
@tmeasday we had this working in the previous version; when there is only one adjacent post, the background image should be the |
Can you check if the picture polyfill is working too? Esp on changing routes. |
@tmeasday when the image is by itself and large, shrinking the viewport to mobile size should change the source to the smaller sized thumbnail. Repro:
|
I think this is sorted now. Bear with me @dominicnguyen ;) |
If you navigate to the first and last products in an index, their adjacent products in the index (the ones at the very bottom of the page) in this case the single adjacent product should use the larger sized image and be wider.
We solve this in the blog with php logic that reads like this:
What is the logic for handlebars?
Screenshot of first product in index' adjacent post:
The text was updated successfully, but these errors were encountered: