PS-4711: crash on TokuDB PFS-instrumented mutexes deinitialization #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-lorch
approved these changes
Aug 9, 2018
| --echo # Stop DB server which was created by MTR default | ||
| --exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect | ||
| --shutdown_server | ||
| --source include/wait_until_disconnected.inc |
There was a problem hiding this comment.
why not --source include/shutdown_mysqld.inc and --source include/start_mysqld.inc ?
There was a problem hiding this comment.
--source include/restart_mysqld.inc must be used here
There was a problem hiding this comment.
laurynas-biveinis
suggested changes
Aug 10, 2018
| --echo # Stop DB server which was created by MTR default | ||
| --exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect | ||
| --shutdown_server | ||
| --source include/wait_until_disconnected.inc |
There was a problem hiding this comment.
--source include/restart_mysqld.inc must be used here
If we look at mysqld_exit(), we will see that shutdown_performance_schema() is always invoked before exit(), what means global mutexes like tokudb_map_mutex are always destroyed after perfomance schema shutdown, what causes SIGFAULT on some platforms(debian wheeze in particular). There are two cases: 1) global mutexes in TokuDB storage engine The fix is in deinitialization of global mutexes explicitly from storage engine shutdown function, which is always invoked before PFS shutdown. 2) global mutexes in PerconaFT There also must be separate patch for PerconaFT to fix it. The fix is in invoking ydb-layer deinitialization function explicitly from storage engine shutdown function.
vlad-lesin
force-pushed
the
pfs-deinit-toku-5.7
branch
from
e0d216f to
d1c43a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we look at mysqld_exit(), we will see that shutdown_performance_schema()
is always invoked before exit(), what means global mutexes like tokudb_map_mutex
are always destroyed after perfomance schema shutdown, what causes SIGFAULT
on some platforms(debian wheeze in particular).
There are two cases:
The fix is in deinitialization of global mutexes explicitly from storage engine
shutdown function, which is always invoked before PFS shutdown.
There also must be separate patch for PerconaFT to fix it. The fix is in
invoking ydb-layer deinitialization function explicitly from storage engine
shutdown function.
Testing:
https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1891/
See also: percona/PerconaFT#414