Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps 5.7 4729 #2483

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Ps 5.7 4729 #2483

merged 2 commits into from
Aug 13, 2018

Conversation

george-lorch
Copy link
Contributor

No description provided.

@george-lorch
Copy link
Contributor Author

Copy link
Contributor

@laurynas-biveinis laurynas-biveinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as for the 5.6 version. IMHO the conversion should be done in 8.0 only, if there are no variables that can be converted from my_bool to bool in lower versions.

George O. Lorch III added 2 commits August 13, 2018 10:15
…d false are valid.

- s/TRUE/true s/FALSE/false and minor conditional corrections for true bool
  types (no my_bool changes).
@george-lorch
Copy link
Contributor Author

Made changes to revert the changes to my_bool types, but fixed/kept minor conditional changes. New jenkins https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1902/.

Since changes here are trivial and jenkins indicates no issue, merging ahead of further approval.

@george-lorch george-lorch merged commit 5287025 into percona:5.7 Aug 13, 2018
@george-lorch george-lorch deleted the ps-5.7-4729 branch August 13, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants