Unset PS build flags in build-binary.sh for jemalloc to use defaults #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurynas-biveinis
added a commit
that referenced
this pull request
Mar 2, 2015
Unset PS build flags in build-binary.sh for jemalloc to use defaults
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Oct 5, 2016
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Test Plan: Manually change latest to `PRIMARY_FORMAT_VERSION_UNPACK_INFO` and run: mysqltest.sh --testset=RocksDB Create database with old version. Recompile code with new version set, and see if it starts up and runs correctly. Reviewers: hermanlee4, spetrunia, jkedgar Reviewed By: jkedgar Subscribers: vasilep, webscalesql-eng Differential Revision: https://reviews.facebook.net/D58503
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Reviewed By: jkedgar Differential Revision: https://reviews.facebook.net/D59469 fbshipit-source-id: 9dec4e27625
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Reviewed By: jkedgar Differential Revision: https://reviews.facebook.net/D59469 fbshipit-source-id: 9dec4e27625
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Nov 4, 2021
First pass at improving the code that controls: - update of cached stats in NDB_SHARE from NDB - initalizing trans table stats - update of handler::stats from NDB_SHARE - update of trans table stats - rounding of handler::stats::records to avoid exact. Improve comments and add some DBUG_PRINT's Rename Trans_table::Stats::records to "table_rows" to avoid uncertainty which records is being updated. Add method for checking if trans table stats are valid i.e has been updated with a rows value from NDB or other cached source. Change-Id: I8f3d614cef0e63c41e93a4b16301292266072379
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Reviewed By: jkedgar Differential Revision: https://reviews.facebook.net/D59469 fbshipit-source-id: 3bb23231c78
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Reviewed By: jkedgar Differential Revision: https://reviews.facebook.net/D59469
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: This changes the PK storage format so that it can contain unpack_info. Currently, the storage format looks like this: | null bits | records for non-packable or non-PK columns | checksum | I am changing the format so that it looks like this: | null bits | unpack_info | records for non-packable or non-PK columns | checksum | The `unpack_info` field looks exactly the same as the one in secondary keys. It is a one-byte tag, followed by two bytes of length information, followed by the actual unpack information. Note that this field may be missing if none of the key columns have a make unpack function set. The main change that needed to be done to support this is to have the `m_make_unpack_info_func` function be available in both `Rdb_field_packing` for `Rdb_key_def::pack_record` and `Rdb_field_encoder` for `ha_rocksdb::convert_record_to_storage_format`. Note that this change isn't active since `PRIMARY_FORMAT_VERSION_UNPACK_INFO` is not the latest. Reviewed By: jkedgar Differential Revision: https://reviews.facebook.net/D59469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix jemalloc build in build-binary.sh script so that it doesn't use build flags from Percona Server but to use default build flags. It was agreed on percona-tokutek mailing list.
autogen.sh generates configure script and was before in jenkins, but since not everybody runs it like we do it's better for it to be in the script.
Here's the test build:
http://jenkins.percona.com/view/Percona-RELEASES/job/percona-server-5.6-binaries-release/96/