-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS-5584 Update PS-5.7 feature comparison #3339
Conversation
doc/source/feature_comparison.rst
Outdated
- 93 | ||
- 61 | ||
* - Global Performance and Status Counters | ||
- 789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was 389 in the original table? And 789 looks too much to me, are you sure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PS Feature Comparison spreadsheet made during 8.0 GA (Tyler)
Global Performance and Status Counters - 789
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, I'm getting 432 on the 5.7 trunk...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 432
doc/source/feature_comparison.rst
Outdated
- Percona Server 5.7.24 | ||
- MySQL 5.7.24 | ||
* - INFORMATION_SCHEMA Tables | ||
- 93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was 75 in the original table - did we implement 18 new since then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PS Feature Comparison spreadsheet made during 8.0 GA (Tyler)
INFORMATION_SCHEMA Tables - 93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just executed show tables
on the current 5.7 turnk, and I see 71 tables - not even 75. So it would be great for somebody who actually does release testing of our software (QA?) to verify these numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should have some doc QA, but realistically, this to me seems like 100% useless information anyway. x number of i_s tables vs y makes not one bit of difference to an end user. What they do care about is what those tables do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other number (432 or 789) is more significant, this one is a smaller difference, but still. I would go with the smaller numbers then - either the original, or what I see with running the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 71.
doc/source/feature_comparison.rst
Outdated
:header-rows: 1 | ||
|
||
* - Features | ||
- Percona Server 5.7.24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be .27 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The information for the PS Feature Comparison was for PS 5.7.24 compared to MySQL 5.7.24.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And did anything change since then? I don't think so, upstream only did bugfixes, same for us. So I would go with .27, since that's the latest version. @georgelorchpercona ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I don't think anything changed so should probably be 5.7.27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to 5.7.27
doc/source/feature_comparison.rst
Outdated
* - Encrypt temporary files | ||
- Yes | ||
- No | ||
* - Key Rotation with scrubbing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrubbing - I wouldn't even call it experimental yet. Also, key rotation and scrubbing are separate things. For several other features here (log encryption for example): these are experimental, not yet GA, I don't think we should write a definite "yes" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with Experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Rotation has its own row. Scrubbing has its own row.
e4d84ab
to
9943bf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing otherwise looks good
doc/source/feature_comparison.rst
Outdated
* - Key Rotation | ||
- Experimental | ||
- No | ||
* - scrubbing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrubbing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Thanks.
Changed layout of tables to list-table Added items from spreadsheet made during the 8.0 GA Updated list based on comments This is a 5.7 ONLY update. There is no 8.0 merge.
9943bf5
to
854e287
Compare
Changed layout of tables to list-table
Added items from spreadsheet made during the 8.0 GA