Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS-7238 - Backport Data Masking plugin to 5.7 #3993

Merged
merged 4 commits into from
Sep 4, 2020
Merged

PS-7238 - Backport Data Masking plugin to 5.7 #3993

merged 4 commits into from
Sep 4, 2020

Conversation

george-lorch
Copy link
Contributor

No description provided.

@george-lorch george-lorch requested a review from dutow August 19, 2020 16:11
@george-lorch
Copy link
Contributor Author

https://ps57.cd.percona.com/job/percona-server-5.7-param/331/

@george-lorch george-lorch changed the title Ps 5.7 7238 - Backport Data Masking plugin to 5.7 PS-7238 - Backport Data Masking plugin to 5.7 Aug 19, 2020
dutow
dutow approved these changes Aug 21, 2020
View reviewed changes
mysql-test/mysql-test-run.pl Outdated
@@ -7453,7 +7453,6 @@ ($)
include-ndb[cluster] Enable all tests that need cluster
do-test=PREFIX or REGEX
Run test cases which name are prefixed with PREFIX
or fulfills REGEX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes, unrelated but seems that it was in the 8.0 commit too /shrug I'll pull it out

fmbiete and others added 3 commits August 21, 2020 11:19
@fmbiete
GPL version of Data Masking for MySQL v5.7 backported from v8.0
655d816 
(cherry picked from commit a209960)
@dutow
PS-5674: Fix mismatched new/delete errors in data_masking plugin
10f77e0 
(cherry picked from commit 78dc716)
@dutow
PS-6733: Use binary search in data masking dictionaries
579356a 
As dictionaries are generated only once, but used many times, this patch
improves the lookup performance by sorting them during load time, and using
binary search during lookups.

(cherry picked from commit db14563)
@george-lorch george-lorch merged commit e9542d4 into percona:5.7 Sep 4, 2020
@george-lorch george-lorch deleted the ps-5.7-7238 branch September 4, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutow dutow dutow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@george-lorch @dutow @fmbiete