PS-1344: Rearrange checks in log_slow_statement() function (5.7) #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-kachan
changed the title
satya-bodapati
requested changes
Jul 12, 2021
https://jira.percona.com/browse/PS-1344 Rearrange PS specific checks in log_slow_statement() function: - Check state of thd->enable_slow_log before doing a bunch of PS specific checks. This allows to find out if slow log is enabled early and avoid unnecessary checks. - Move collecting of query_exec_time up, do it right after thd->enable_slow_log is checked. Getting query_exec_time earlier before performing PS speciffic checks will give a more precise duration. - Copy global vars into session ones before doing checks where this value is actually used, do it as the next step after query_exec_time calculation.
oleksandr-kachan
force-pushed
the
PS-1344-5.7
branch
from
ef61c0e to
8d38668
Compare
Yes, this is just a refactoring. I've extended description a bit, not sure there is anything more to be added there. |
Ok, if it is refactoring, then it is fine. It looked like it could result in some improvements. |
satya-bodapati
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PS-1344
Rearrange PS specific checks in log_slow_statement() function:
of PS specific checks. This allows to find out if slow log is
enabled early and avoid unnecessary checks.
thd->enable_slow_log is checked. Getting query_exec_time earlier
before performing PS speciffic checks will give a more precise
duration.
value is actually used, do it as the next step after query_exec_time
calculation.