PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor #5032

dutow · 2023-03-29T10:06:23Z

https://jira.percona.com/browse/PS-8188

Problem:
--------
Clone enforces donor and recipient have same plugins installed.
For example, if a donor has an extra authentication plugin or a data masking plugin
installed but not installed on recipient, it is not possible to clone.
It will fail with the below error.

'Clone Donor plugin <plugin_name> is not active in Recipient.'

Fix:
----
Introduce new clone option 'clone_exclude_plugins_list' to take list of plugins that
are not installed on recipient.

This option is used on recipient server. The following plugins are disallowed. They must
be installed on recipient.

"daemon_keyring_proxy_plugin",
"binlog",
"performance_schema",
"memory",
"innodb",
"keyring_file",
"keyring_vault",
"group_replication"

plugin/clone/src/clone_plugin.cc

satya-bodapati · 2023-04-04T19:03:03Z

@dutow Can u please get Jenkins run?

satya-bodapati · 2023-05-09T12:36:39Z

@dutow LGTM! Please ensure clean Jenkins before merge.

…pient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault", "group_replication"

…pient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com>

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com>

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> -------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> -------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> -------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> -------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> --------------------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

…o match on recipient/donor (percona#5032) PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor https://jira.percona.com/browse/PS-8188 Problem: -------- Clone enforces donor and recipient have same plugins installed. For example, if a donor has an extra authentication plugin or a data masking plugin installed but not installed on recipient, it is not possible to clone. It will fail with the below error. 'Clone Donor plugin <plugin_name> is not active in Recipient.' Fix: ---- Introduce new clone option 'clone_exclude_plugins_match' to take list of plugins that are not installed on recipient. This option is used on recipient server. The following plugins are disallowed. They must be installed on recipient. "daemon_keyring_proxy_plugin", "binlog", "performance_schema", "memory", "innodb", "keyring_file", "keyring_vault" Co-authored-by: Satya Bodapati <satya.bodapati@percona.com> -------------------------------------------------------------------------- PS-8844: Fix the failing clone.plugin_mismatch https://jira.percona.com/browse/PS-8844 The test clone.plugin_mismatch fails when run from installed directories due to the different path of the plugin directory used by the test. Failure: CURRENT_TEST: clone.plugin_mismatch mysqltest: At line 28: Command "remove_file" failed with error 1. my_errno=2. The test involves simulating the secnario of missing plugins on recipient server. To do the same, the test earlier used to copy all plugins to recipient server's plugin_dir and delete some plugins to test the clone plugin's behavior when recipeint had some plugins missing. During the test investigation, it was found that it is just sufficient to have only the clone plugin copied to the recipient server so that it simulates the missing plugins. This patch makes the the test independent of plugin paths so it works on both build and installed directories.

dutow requested a review from satya-bodapati March 29, 2023 10:06

satya-bodapati requested changes Apr 4, 2023

View reviewed changes

plugin/clone/src/clone_plugin.cc Outdated Show resolved Hide resolved

dutow force-pushed the PS-8.0-8188 branch from f0ca67e to ba5261a Compare May 9, 2023 09:21

dutow requested a review from satya-bodapati May 9, 2023 09:23

satya-bodapati approved these changes May 9, 2023

View reviewed changes

satya-bodapati and others added 3 commits May 21, 2023 16:20

clang format test fix

5412907

PS-8188: Fixing review comments

cc0b3d6

dutow force-pushed the PS-8.0-8188 branch from ba5261a to cc0b3d6 Compare May 21, 2023 14:21

dutow changed the base branch from 8.0 to release-8.0.33-25 May 22, 2023 12:01

dutow merged commit 7ae09fd into percona:release-8.0.33-25 May 22, 2023

dutow mentioned this pull request May 22, 2023

PS-8188 : Make the clone_plugin to not force plugins to match on reci… #4846

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor #5032

PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor #5032

dutow commented Mar 29, 2023

satya-bodapati commented Apr 4, 2023

satya-bodapati commented May 9, 2023

PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor #5032

PS-8188 : Make the clone_plugin to not force plugins to match on recipient/donor #5032

Conversation

dutow commented Mar 29, 2023

satya-bodapati commented Apr 4, 2023

satya-bodapati commented May 9, 2023