Bug904714 5.6 #959
Merged
Bug904714 5.6 #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing testcase sets up circular replication between two servers, issues a workload, syncs the servers, and checks that master binlog position on one server is equal to Exec_Master_Log_Pos. The testcase intermittently fails that positions are not equal, and when it does, the 1st server points to the position of 2nd server that comes before the 1st->2nd replicated events, i.e. while the data is in sync, the positions aren't, for that the 1st server should receive back its own events from the 2nd server, and advance log positions without executing them. This is caused by rpl_sync.inc include file rpl_generate_sync_chain.inc generating sync chains that propagate all the data but not necessarily the log positions as described above in case of loops. Fix by performing one more synchronisation step in the loop.
|
LGTM |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Test Plan: Run newly added test case Originally Reviewed By: santoshb Reviewed By: lth Differential Revision: D14137362 Pulled By: lth fbshipit-source-id: d391cadaa83
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Test Plan: Run newly added test case Originally Reviewed By: santoshb Reviewed By: lth Differential Revision: D14137362 Pulled By: lth fbshipit-source-id: d391cadaa83
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 (facebook/mysql-5.6@3889d13) Pulled By: lth fbshipit-source-id: 7fbd7ced083
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 18, 2022
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Apr 12, 2022
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
…percona#959) Summary: Jira ticket: https://jira.percona.com/browse/FB8-53 Reference Patch: facebook/mysql-5.6@f29eb03 Reference Patch: facebook/mysql-5.6@c631017 'THD' class extended with the following convenience methods: - 'has_net_vio()' - 'get_net_vio()' - 'has_net_vio_ssl_arg()' - 'get_net_vio_ssl_arg()' - 'get_peer_certificate_info()' Implemented new 'Fill_authinfo_list' class derived from 'Do_THD_Impl' which populates 'INFORMATION_SCHEMA.AUTHINFO' table. This is a change to help the implementation of SSL based authentication efforts. Currently the certificate details are unavailable to the sys admin. The v3 extensions usually carry important information for identifying the user. This change adds a new table to the information schema to expose auth details. It is organized by process ID like processlist table. Pull Request resolved: facebook/mysql-5.6#959 Reviewed By: lloyd Differential Revision: D14137362 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jenkins.percona.com/job/percona-server-5.6-param/1353/