-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partition_prune testcase #440
Conversation
This reverts commit f0b85b8.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=======================================
Coverage 90.55% 90.56%
=======================================
Files 3 3
Lines 1271 1272 +1
Branches 35 35
=======================================
+ Hits 1151 1152 +1
Misses 98 98
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Any reason that in this PR we have this setting only for postgresql-14-build & postgresql-15-build ('compute_query_id = regress). But not for postgresql-16-build where it is still (compute_query_id = off)? Am i missing something? :) |
|
Then I guess, somehow GH was showing me wrong diff of changes. But change is reflected in your working branch. :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes #423
compute_query_id
parameter has special valueregress
that allowspg_stat_monitor
to have query identifier but hides it inEXPLAIN
s to let regression testing pass.https://www.postgresql.org/docs/current/runtime-config-statistics.html#GUC-COMPUTE-QUERY-ID