Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for editing services for mysql, pgsql, proxysql and mongo, rds, azzure #680

Merged
merged 26 commits into from
Oct 13, 2023

Conversation

saikumar-vs
Copy link
Contributor

@saikumar-vs saikumar-vs commented Sep 4, 2023

puneet0191
puneet0191 previously approved these changes Sep 4, 2023
Copy link
Collaborator

@puneet0191 puneet0191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just ensure you have checked with Upgrade tests also once using this custom branch

@saikumar-vs saikumar-vs changed the title Initial tests for mysql, pgsql, proxysql and mongo Tests for editing services for mysql, pgsql, proxysql and mongo, rds, azzure Sep 11, 2023
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
vyarosh
vyarosh previously approved these changes Oct 3, 2023
Copy link
Contributor

@vyarosh vyarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@yurkovychv yurkovychv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after providing fixes please run ui-tests-matrix and nightly

tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
tests/configuration/pages/pmmInventoryPage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@yurkovychv yurkovychv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saikumar-vs saikumar-vs merged commit 768e858 into main Oct 13, 2023
9 of 11 checks passed
@saikumar-vs saikumar-vs deleted the PMM-T2340 branch October 13, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants