PMM-12678 Reset protobuf field nums, remove all deprecated stuff from…

… API (#2733)

* PMM-12678 Reorder protobuf fields

* PMM-12678 Fix tests

* PMM-12678 Mark some fileds as reserved

* PMM-12678 Cleanup

* PMM-12678 Fix tests

* PMM-12678 Fix tests

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Cleanup

* PMM-12678 Fix mocks

* PMM-12678 Fix proto fields numbering

agent/agents/mongodb/internal/profiler/profiler_test.go

@@ -188,7 +188,7 @@ func testProfiler(t *testing.T, url string) {
 		assert.Equal(t, "INSERT people", bucket.Common.Fingerprint)
 		assert.Equal(t, []string{"people"}, bucket.Common.Tables)
 		assert.Equal(t, "test-id", bucket.Common.AgentId)
-		assert.Equal(t, inventoryv1.AgentType(9), bucket.Common.AgentType)
+		assert.Equal(t, inventoryv1.AgentType(10), bucket.Common.AgentType)
 		expected := &agentv1.MetricsBucket_MongoDB{
 			MDocsReturnedCnt:   docsCount,
 			MResponseLengthCnt: docsCount,

agent/agents/mysql/slowlog/slowlog_expected.json

@@ -7,7 +7,7 @@
 			"fingerprint": "select name, subsystem, type, comment, count from information_schema.innodb_metrics where status = ?",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "SELECT\n\t\t  name, subsystem, type, comment,\n\t\t  count\n\t\t  FROM information_schema.innodb_metrics\n\t\t  WHERE status = 'enabled'",
@@ -52,7 +52,7 @@
 			"schema": "sbtest",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "SELECT pad FROM sbtest1 WHERE id=775815",
@@ -95,7 +95,7 @@
 			"fingerprint": "ping",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "Ping",
@@ -126,7 +126,7 @@
 			"fingerprint": "show global status",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "SHOW GLOBAL STATUS",
@@ -170,7 +170,7 @@
 			"fingerprint": "set lock_wait_timeout=?",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "SET lock_wait_timeout=2",
@@ -201,7 +201,7 @@
 			"fingerprint": "select @@version",
 			"username": "root",
 			"agent_id": "/agent_id/73ee2f92-d5aa-45f0-8b09-6d3df605fd44",
-			"agent_type": 8,
+			"agent_type": 9,
 			"period_start_unix_secs": 1557137220,
 			"period_length_secs": 60,
 			"example": "SELECT @@version",

agent/connectionchecker/connection_checker_test.go

@@ -247,8 +247,6 @@ func TestConnectionChecker(t *testing.T) {
 			Type: inventoryv1.ServiceType_SERVICE_TYPE_MYSQL_SERVICE,
 		}, 0)
 		require.NotNil(t, resp)
-		// CheckConnectionResponse_Stats are deprecated, but we can't remove them yet without breaking older clients.
-		assert.Equal(t, (*agentv1.CheckConnectionResponse_Stats)(nil), resp.Stats) //nolint:staticcheck
 	})
 
 	t.Run("MongoDBWithSSL", func(t *testing.T) {