Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Fix go-tip github workflow. #2117

Closed
wants to merge 8 commits into from
Closed

Conversation

PavelKhripkov
Copy link
Contributor

@PavelKhripkov PavelKhripkov commented May 11, 2023

PMM-7

Didn't test the changes. Do you guys think I should? Or we can just wait for the date specified in scheduler.

@PavelKhripkov PavelKhripkov marked this pull request as ready for review May 11, 2023 15:53
@PavelKhripkov PavelKhripkov requested review from a team as code owners May 11, 2023 15:53
@PavelKhripkov PavelKhripkov requested review from BupycHuk, artemgavrilov, a user, ademidoff and idoqo and removed request for a team May 11, 2023 15:53
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2117 (da5b273) into main (8b427cd) will decrease coverage by 0.62%.
The diff coverage is n/a.

❗ Current head da5b273 differs from pull request most recent head e5fab3e. Consider uploading reports for the commit e5fab3e to get more accurate results

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
- Coverage   42.58%   41.97%   -0.62%     
==========================================
  Files         387      387              
  Lines       47651    47651              
==========================================
- Hits        20291    20000     -291     
- Misses      25452    25779     +327     
+ Partials     1908     1872      -36     
Flag Coverage Δ
admin 10.46% <ø> (-0.05%) ⬇️
agent 49.83% <ø> (-2.94%) ⬇️
vmproxy 70.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff
Copy link
Member

PMM-7

Didn't test the changes. Do you guys think I should? Or we can just wait for the date specified in scheduler.

I think we can test the changes by temporarily replacing these with pull_request:.

@PavelKhripkov PavelKhripkov enabled auto-merge (squash) May 12, 2023 10:03
@PavelKhripkov PavelKhripkov disabled auto-merge May 16, 2023 21:15
@PavelKhripkov PavelKhripkov disabled auto-merge May 17, 2023 09:44
@artemgavrilov
Copy link
Contributor

@PavelKhripkov yesterday on BE call we agreed to remove tip builds: #2137
So this PR can be closed.

@PavelKhripkov PavelKhripkov deleted the PMM-7-fix-gotip-workflow branch May 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants