Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 fix caching of modules #2128

Closed
wants to merge 9 commits into from
Closed

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented May 15, 2023

PMM-7

Why:
We see a lot of errors when github actions/cache@v3 tries to restore files from cache. Meanwhile, v4 of actions/setup-go enables cache by default, which make the use of a separate action redundant.

In this PR we will try to fix that. We'll still use actions/cache@v3 for tip versions of go.

Note:
It seems like modules in directories /tools and api-tests/tools won't be cached, since actions/setup-go is able to use only one go.sum file, which in our case resides in the root folder. TODO: see if/how we can leverage the cache-dependency-path parameter.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2128 (2b38935) into main (8b427cd) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
+ Coverage   42.58%   42.59%   +0.01%     
==========================================
  Files         387      387              
  Lines       47651    47651              
==========================================
+ Hits        20291    20299       +8     
+ Misses      25452    25445       -7     
+ Partials     1908     1907       -1     
Flag Coverage Δ
agent 52.91% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff ademidoff marked this pull request as ready for review May 15, 2023 12:04
@ademidoff ademidoff requested review from a team as code owners May 15, 2023 12:04
@ademidoff ademidoff requested review from BupycHuk, artemgavrilov, a user, idoqo and rishat-ishbulatov and removed request for a team May 15, 2023 12:04
@ademidoff ademidoff changed the title PMM-7 try to fix caching for the agent PMM-7 fix caching of modules May 15, 2023
Copy link
Contributor

@artemgavrilov artemgavrilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge, I have concerns.

@ademidoff
Copy link
Member Author

Closing this in favor of #2137

@ademidoff ademidoff closed this May 17, 2023
@ademidoff ademidoff deleted the PMM-7-fix-go-modules-cache branch May 17, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants