-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-7 fix caching of modules #2128
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
+ Coverage 42.58% 42.59% +0.01%
==========================================
Files 387 387
Lines 47651 47651
==========================================
+ Hits 20291 20299 +8
+ Misses 25452 25445 -7
+ Partials 1908 1907 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge, I have concerns.
Closing this in favor of #2137 |
PMM-7
Why:
We see a lot of errors when github
actions/cache@v3
tries to restore files from cache. Meanwhile, v4 ofactions/setup-go
enables cache by default, which make the use of a separate action redundant.In this PR we will try to fix that. We'll still use
actions/cache@v3
for tip versions ofgo
.Note:
It seems like modules in directories
/tools
andapi-tests/tools
won't be cached, sinceactions/setup-go
is able to use only onego.sum
file, which in our case resides in the root folder. TODO: see if/how we can leverage thecache-dependency-path
parameter.