PMM-12576 Change admin ID on update. #2531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
artemgavrilov
and removed request for
a team
|
@BupycHuk I see the FB container failed... I suppose we need to be sure it builds OK to be able to test it. |
ademidoff
requested changes
Oct 16, 2023
| @@ -160,6 +163,12 @@ | |||
| - skip_ansible_lint # '503 Tasks that run when changed should likely be handlers'. | |||
| when: is_database_sqlite.stat.exists | |||
|
|
|||
| - name: Change default admin id | |||
There was a problem hiding this comment.
I don't think we need it here since the same will run on each container start in update/ansible/playbook/tasks/update.yml.
There was a problem hiding this comment.
it shouldn't, because there are when condition for the whole block and update.yml doesn't work for docker-way upgrade.
1 task
artemgavrilov
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12576
Link to the Feature Build: SUBMODULES-3411
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: