Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-8019 Support partial updates of settings and other entities #2705

Merged
merged 24 commits into from
Dec 27, 2023

PMM-8019 Fix

ca6219a
Select commit
Loading
Failed to load commit list.
Merged

PMM-8019 Support partial updates of settings and other entities #2705

PMM-8019 Fix
ca6219a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 26, 2023 in 0s

43.37% (+0.00%) compared to 5ee16cf

View this Pull Request on Codecov

43.37% (+0.00%) compared to 5ee16cf

Details

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (5ee16cf) 43.36% compared to head (ca6219a) 43.37%.

Files Patch % Lines
managed/services/server/server.go 53.65% 11 Missing and 8 partials ⚠️
managed/utils/envvars/parser.go 61.53% 15 Missing ⚠️
managed/services/platform/platform.go 0.00% 8 Missing ⚠️
managed/models/settings_helpers.go 75.86% 3 Missing and 4 partials ⚠️
managed/services/management/alerting/service.go 0.00% 4 Missing and 3 partials ⚠️
managed/services/management/checks.go 12.50% 6 Missing and 1 partial ⚠️
managed/models/user_flags_helpers.go 0.00% 6 Missing ⚠️
managed/models/settings.go 87.50% 4 Missing and 1 partial ⚠️
...aged/services/management/backup/backups_service.go 60.00% 2 Missing and 2 partials ⚠️
managed/services/management/role.go 60.00% 3 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           v3-api-breaking-changes    #2705   +/-   ##
========================================================
  Coverage                    43.36%   43.37%           
========================================================
  Files                          361      361           
  Lines                        42431    42410   -21     
========================================================
- Hits                         18401    18396    -5     
+ Misses                       22462    22451   -11     
+ Partials                      1568     1563    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov