PMM-9288 Extended profiler. #3662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3662 +/- ##
==========================================
+ Coverage 43.62% 43.73% +0.11%
==========================================
Files 366 366
Lines 44328 44417 +89
==========================================
+ Hits 19338 19427 +89
+ Misses 23310 23308 -2
- Partials 1680 1682 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
commented
Feb 21, 2025
Comment on lines
-291
to
-295
| bucket.Mongodb.MDocsScannedCnt = float32(v.Count) // TODO: Check is it right value | ||
| bucket.Mongodb.MDocsScannedMax = float32(v.Scanned.Max) | ||
| bucket.Mongodb.MDocsScannedMin = float32(v.Scanned.Min) | ||
| bucket.Mongodb.MDocsScannedP99 = float32(v.Scanned.Pct99) | ||
| bucket.Mongodb.MDocsScannedSum = float32(v.Scanned.Total) |
JiriCtvrtka
requested review from
ademidoff,
idoqo and
igroene
and removed request for
a team
JiriCtvrtka
commented
Feb 21, 2025
Comment on lines
-304
to
+303
| bucket.Mongodb.MFullScanSum = float32(v.CollScanSum) / 1000 | ||
| bucket.Mongodb.MFullScanSum = float32(v.CollScanCount) // Sum is same like count in this case |
There was a problem hiding this comment.
@igroene please check if in case of Full Scan (CollScan in Mongo) are Sum and Count values same.
This was referenced Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9288
Link to the Feature Build: SUBMODULES-0
Percona Toolkit: PMM-9288 Extended profiler. percona-toolkit#924
Grafana Dashboards: PMM-9288 Extended profiler. grafana-dashboards#1656
FB: PMM-9288 Extended profiler. Percona-Lab/pmm-submodules#3856