PMM-7806: add compatibility with percona pg exporter #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritbl
commented
May 22, 2022
| @@ -0,0 +1,1049 @@ | |||
| # HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles. | |||
There was a problem hiding this comment.
Baseline, output from Percona Exporter running in pmm devcontainer (2.28.0)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| referenceMetrics := toMap(t, referenceMetrics) | ||
|
|
||
| //remove matches | ||
| for m, _ := range currentMetrics { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
S1005: unnecessary assignment to the blank identifier (gosimple)
BupycHuk
approved these changes
Aug 2, 2022
| @@ -0,0 +1,143 @@ | |||
| package main | |||
There was a problem hiding this comment.
Was this file created to make it easier to support upstream changes?
There was a problem hiding this comment.
yep, to separate our code from upstream
JiriCtvrtka
approved these changes
Aug 8, 2022
ritbl
added a commit
to heniek/postgres_exporter
that referenced
this pull request
Mar 19, 2023
* add compatibility with old exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7806
Feature Build:
Related PRs: