Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-9973 Resolutions fix #2 #73

Merged
merged 5 commits into from
Sep 6, 2022
Merged

PMM-9973 Resolutions fix #2 #73

merged 5 commits into from
Sep 6, 2022

Conversation

tshcherban
Copy link

No description provided.

@tshcherban
PMM-9973 resolutions filtering fix
9c6401f 
(cherry picked from commit 0f388cf)
@tshcherban
PMM-9973 resolutions filtering fix
08daf5e 
(cherry picked from commit fa73ee0)
@tshcherban
PMM-9973 lint disable
b80c436 
(cherry picked from commit 43f7dd1)
@tshcherban
PMM-9973 add postgres collector to registry
be4cbc3 
(cherry picked from commit ca64787)
@tshcherban
PMM-9973 debug code remove
ae05f74 
(cherry picked from commit 588c2b1)
@tshcherban tshcherban requested a review from a team as a code owner September 6, 2022 11:15
@tshcherban tshcherban temporarily deployed to CI September 6, 2022 11:15 Inactive
@tshcherban tshcherban temporarily deployed to CI September 6, 2022 11:15 Inactive
@tshcherban tshcherban temporarily deployed to CI September 6, 2022 11:15 Inactive
@tshcherban tshcherban temporarily deployed to CI September 6, 2022 11:15 Inactive
@tshcherban tshcherban temporarily deployed to CI September 6, 2022 11:15 Inactive
JiriCtvrtka
JiriCtvrtka reviewed Sep 6, 2022
View reviewed changes
cmd/postgres_exporter/main.go
handler := promhttp.HandlerFor(
registry,
promhttp.HandlerOpts{
//ErrorLog: log.NewNopLogger() .NewErrorLogger(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this.

@tshcherban tshcherban merged commit ae78ab2 into main Sep 6, 2022
@tshcherban tshcherban deleted the PMM-9973-pr branch September 6, 2022 11:32
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
@tshcherban
PMM-9973 Resolutions fix #2 (percona#73)
65766f8 
* PMM-9973 resolutions filtering fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriCtvrtka JiriCtvrtka JiriCtvrtka approved these changes

@percona-csalguero percona-csalguero Awaiting requested review from percona-csalguero percona-csalguero is a code owner automatically assigned from percona/pmm-review-exporters

@ShashankSinha252 ShashankSinha252 Awaiting requested review from ShashankSinha252 ShashankSinha252 is a code owner automatically assigned from percona/pmm-review-exporters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshcherban @JiriCtvrtka