🐛 Fix sdk-utils websocket constructor hanging #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
It seems that the WebSocket constructor can sometimes cause browsers to hang during the initial handshake. This PR adjusts
@percy/sdk-utilsremote logger connection to start the timeout immediately, before a WebSocket is even created. This should cause the resulting promise to be rejected if the WebSocket constructor hangs for more than the default 1s timeout. This timeout is not visible outside of debug logs since remote logging connections aren't required for SDKs to work with the CLI. Unfortunately, a test for this cannot be added without blocking the event loop.